Re: Memory leak in sys/external/bsd/ipf/netinet/ip_fil_netbsd.c:ipf_send_ip()?

[christos%astron.com@localhost (Christos Zoulas)]

In article <Ynpr4ly3Ix0lGkDZ%trav.math.uni-bonn.de@localhost>,
Edgar Fuß  <ef%math.uni-bonn.de@localhost> wrote:
>I'm not sure if that code can be actually reached, but I'm under the impression 
>that there's a memory leak in external/bsd/ipf/netinet/ip_fil_netbsd.c in 
>ipf_send_ip():
>
>static int
>ipf_send_ip(fr_info_t *fin, mb_t *m)
>{
>[...]
>	switch (fin->fin_v)
>	{
>#ifdef INET
>	case 4 :
>[...]
>#endif
>#ifdef USE_INET6
>	case 6 :
>[...]
>#endif
>	default :
>		return EINVAL;
>	}
>[...]
>	return ipf_fastroute(m, &m, &fnew, NULL);
>}
>
>In the normal case, m is eventually freed by ipf_fastroute(). But in the 
>default: case, it looks like there's a
>	FREE_MB_T(m);
>missing.

There is a leak there, but how often does it fire? I think looks like an
error if it is not 4 or 6.

christos