tech-net archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: IFF_OACTIVE -- is it still relevant?



Bumping this thread...

> On Jan 22, 2020, at 4:16 AM, Joerg Sonnenberger <joerg%bec.de@localhost> wrote:
> 
> On Fri, Jan 17, 2020 at 02:19:24PM -0800, Jason Thorpe wrote:
>> In some ways, I question the utility of IFF_OACTIVE .. at best, it
>> avoids calling (*if_start)() if there are no transmit slots
>> available... but that situation is something that (*if_start)()
>> routines need to handle anyway.
> 
> That would be better served by an estimate of the number of open and
> in-flight transmit slots, something a queueing discipline might care
> for. As is, I see little reason for preserving IFF_OACTIVE in the
> current form and would suggest to just drop it.

Yes, this is the direction I plan to go forward with.

I will start by G/C'ing IFF_OACTIVE usage in individual drivers that are easy to handle, and then slowly move on to the more difficult tiers.

-- thorpej



Home | Main Index | Thread Index | Old Index