Re: bridge(4) - feedback local packets into ether_input()

[Roy Marples <roy%marples.name@localhost>]

On 22/04/2016 02:14, Roy Marples wrote:
> Because DHCP is essentially a broadcast operation, I copied the logic
> from bridge_broadcast() into bridge_output() (used for originating local
> packets) where we send the packet to ether_input() if it's broadcast or
> multicast. Because bridge_output has coding for if src_if == dst_if I
> reversed the logic on sending it to ether_input (src_if != dst_if) so
> that the receiving interface doesn't double up.

Nick suggested just to use bridge_broadcast() and came up with this
patch: http://www.netbsd.org/~skrll/bridge.diff

(note doesn't compile, src_if needs replacing with ifp)

However, this makes the kernel panic with locking against myself on
softnet_lock which we cannot figure out.

Is this an easy fix or should we forget it and go back to the initial patch?

Roy