tech-net archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: patch: sockaddr instead of mbuf to carry addresses
Tyler Retzlaff <rtr%netbsd.org@localhost> wrote:
> hi,
>
> attached is the first of a set of patches intended to remove the use of
> mbuf as a bucket to carry sockaddr structures for per-user requests.
> this patch introduces the structure required and changes bind.
>
> i've been running it myself, the atf tests work with it and there has
> been some private review prior to posting.
>
> comments welcome
>
Thanks for working on this.
Unfortunately, I have not had time for a careful review, but from a quick
check of the key parts it looks good. One issue: why struct sockaddr_big?
I think we can and should use struct sockaddr_storage for this. Also, is
there any reason why the address parameter could not be const?
--
Mindaugas
Home |
Main Index |
Thread Index |
Old Index