[Greg Troxel] CVS commit: src/usr.sbin/mrouted

[Greg Troxel <gdt%ir.bbn.com@localhost>]

I would say this shows that no one uses multicast :-(

I have a number of fixes from a private tree that I will be applying as
I am able.  All of them have seen extensive testing in a
heavily-modified netbsd-6 tree and were subject to internal code review
at BBN.  Therefore, when they apply cleanly to current and my read is
that the fix is clearly still right, I'm going to just apply, compile
test (multiple arches) and commit, aiming for zero breakage.

--- Begin Message ---

• To: source-changes%NetBSD.org@localhost
• Subject: CVS commit: src/usr.sbin/mrouted
• From: "Greg Troxel" <gdt%netbsd.org@localhost>
• Date: Thu, 5 Feb 2015 16:50:20 +0000

Module Name:	src
Committed By:	gdt
Date:		Thu Feb  5 16:50:19 UTC 2015

Modified Files:
	src/usr.sbin/mrouted: vif.c

Log Message:
Fix bug in mrouted about aging neighbors.

mrouted will periodically age its neighbors and will remove a neighbor
if it hasn't heard from it for NEIGHBOR_EXPIRE_TIME. Unfortunately, the
neighbor pointers 'a' and 'prev_a' were never advanced when timer was
not expired. Therefore it would get stuck in a tight loop, advancing
'al_timer' until it would be greater than NEIGHBOR_EXPIRE_TIME. This
caused the neighbor to allways get timed out and dropped. Furthermore,
there was a second bug in this loop when deleting an item that was not
at the head of the list (i.e., prev_a should stay the same instead of
advancing).

This bug fix is the work of Konrad Lorincz.  Bug found and fix made on
netbsd-6.

This material is based upon work supported by the Defense Advanced
Research Projects Agency and Space and Naval Warfare Systems Center,
Pacific, under Contract No. N66001-09-C-2073.  Any opinions, findings
and conclusions or recommendations expressed in this material are
those of the author(s) and do not necessarily reflect the views of the
Defense Advanced Research Project Agency and Space and Naval Warfare
Systems Center, Pacific.
Approved for Public Release, Distribution Unlimited


To generate a diff of this commit:
cvs rdiff -u -r1.18 -r1.19 src/usr.sbin/mrouted/vif.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

--- End Message ---