tech-net archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: wm_intr may lead wm_start unexpectedly



On Wed, Jun 25, 2014 at 11:57:11AM +0200, Manuel Bouyer wrote:
> On Wed, Jun 25, 2014 at 06:51:06PM +0900, Ryota Ozaki wrote:
> > >> Any comments?
> > >
> > > why not change in6_if_link_up() to use a delay >= 1 instead of 0 ?
> > 
> > My change intends to make it clear whether a callout will be used
> > or not. I think it's error-prone.
> 
> for me, it's clear that a timeout of 0 means immediately, and so a
> callout is not needed.

It's an ugly old technique to defer execution to non-interrupt context,
is it not, dating from before we had the softint framework?  It was all
over the original RNG code (I ripped it out).

Thor


Home | Main Index | Thread Index | Old Index