tech-net archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: nd6_rtr.c possible buffer overflow ?

On Thu, Oct 03, 2013 at 08:58:17AM -0700, Loganaden Velvindron wrote:
> Assuming that if_name(ifp) is the maximum size, wouldn't that possibly lead to
> an unterminated string.

Maximum size includes the \0?

> In such a case, wouldn't strlcpy be better ?

Not for the given reason, but it would be slightly less awful in terms
of performance as ifra is already zero initialised before. If changing
it, it should still get an explicit comment about that as we don't want
to leak content of the kernel stack.


Home | Main Index | Thread Index | Old Index