Re: bridge diffs

[Robert Swindells <rjs%fdy2.co.uk@localhost>]

Darren Reed wrote:
>What is the goal of the bpf_mtap() calls in bridge_input()?

Help people work out whether their bridge is set up correctly.

>At present, they reflect what packets are sent, rather than
>what is actually received. There are many paths through
>bridge_input() for a received packet to not be returned via
>bpf and that concerns me because a received packet may go
>missing when in fact it should be recorded.

I felt that it was more useful to only log packets that are being
transferred across the bridge.

It is easy enough to apply a tap to a member interface as well to
see any differences.

Robert Swindells