tech-net archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: apparently missing locking in if_bnx.c

Manuel Bouyer <> writes:

> I agree that patches to get rid of spl locking in drivers should not 
> be rejected. But if a driver is made SMP-safe just to "fix" a bug,
> then it's not the right thing to do because the bug is still there.

No argument on this from me.   There's pretty clearly something off in
the grand scheme of how splnet/kernel_lock is supposed to protect
bnx_start, and we definitely need to get to the bottom of it.

Attachment: pgpofn8muAKaj.pgp
Description: PGP signature

Home | Main Index | Thread Index | Old Index