Re: ip_flow.c ipf struct member ipf_start

["Liam J. Foy" <liamjfoy%gmail.com@localhost>]

On 19 January 2012 19:12, Bernd Ernesti <netbsd%lists.veego.de@localhost> wrote:
> On Tue, Jan 17, 2012 at 05:15:02PM +0000, Liam J. Foy wrote:
>> hi,
>>
>> i appreciate this is only a minor nit. however...
>>
>> ip_flow.c contains the struct ipf which in turn contains a member
>> called ipf_start. this member is never used (only assigned, never
>> read) and I can't see a time it ever was. i was going to remove it but
>> another developer pointed out it might have been used for debugging
>> but no one knows.
>>
>> i propose to remove it completely or #ifdef the member.
>>
>> any comments?
>
> Where is the issue with the member and what is FreeBSD using?
>
> Bernd
>
>

Hi Bernd,

The issue was minor - it wasn't used.

FreeBSD now have another implementation entirely.

Regards,

-- 
Liam J. Foy