New frag6_in function (was: CVS commit: src/sys/netinet6)

[Bernd Ernesti <netbsd%lists.veego.de@localhost>]

Hi,

On Fri, Nov 04, 2011 at 12:22:34AM +0000, Zoltan Arnold NAGY wrote:
> Module Name:  src
> Committed By: zoltan
> Date:         Fri Nov  4 00:22:34 UTC 2011
> 
> Modified Files:
>       src/sys/netinet6: frag6.c ip6_var.h
> 
> Log Message:
> Change the IPv6 reassembly mechanism to use mutex(9).
> Also add ip6_reass_packet() to be used by NPF.
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.49 -r1.50 src/sys/netinet6/frag6.c
> cvs rdiff -u -r1.55 -r1.56 src/sys/netinet6/ip6_var.h

I can't comment on the actual mutex changes but the return
handling in the 'new' frag6_in function is questionable for me.

Why did you create a new wrapper around the old frag6_input
and replace the return IPPROTO_DONE with a 'return -1' inside
it?

If you really need a special handling for NPF I would have not
gone this way by creating two wrappers around a renamed
frag6_input. Just create one wrapper (ip6_reass_packet) around
the old frag6_input and describe a little bit in that function
why you need this handling there.
Do the new function belongs in frag6.c or where should it be placed?

Btw searching for frag6_in would also match frag6_insque
so the shortened name is not a good one either.

Bernd