tech-net archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: 16 year old bug [with non-contiguous netmasks]

> > > Fix a 16 year old bug in the sorting routine for non-contiguous netmasks.
> > I suggest removing support for non-contiguous netmasks.  They are
> Then please find another way for IPsec to match packets, before you rip
> out the one it uses now.

If you can't rely on the masks being contiguous, why not use (e.g.)
heapsort instead? I'd think the whole reason you have the specific
netmask-sorting algo is for the optimized case where you _do_ have
contiguous netmasks; if that doesn't hold, though, you may as well
use something that's already in the kernel and (presumably) tuned.

Home | Main Index | Thread Index | Old Index