tech-net archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Another update for axe(4)

On 06/17/10 01:25, Paul Goyette wrote:
I will investigate later today.  My file/build server at home is down at
the moment, and I am at work.

in axe_attach(), axe_lock_mii() should be placed before axe_cmd(AXE_CMD_READ_PHYID).

in axe_init(), lock/unlock should be added around axe_cmd(AXE_178_CMD_WRITE_NODEID).

I think axe_{lock,unlock}_mii() can be reduced, but it can do after commit. some part that you merged from my patch (incomplete, as I said;) should be fixed too, but I don't think it's critial.

I have no objection to commit your code!


Home | Main Index | Thread Index | Old Index