tech-net archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: rbuf starvation in the iwn driver

On Mon April 12 2010 00:31:48 matthew green wrote:
>    On Sat, Apr 10, 2010 at 12:49:48PM +1000, matthew green wrote:
>    > would you try this variant?  it handles the case where MEXTMALLOC()
>    > would fail to allocate external storage, and seems to work on my
>    > iwn(4).  i'll commit this if you confirm it works.
>    Is there any reason not to replace the implementation of
>    iwn_alloc_rbuf() with MEXTMALLOC(), instead?
> as in hide this inside iwn_alloc_rbuf()?  probably.  or do you
> mean give up the private buffer collection?  in that case, i
> am not sure what the right solution would be, seems like a
> concept we want to decide for (all?) network drivers...

I suggest we deviate as little as possible from the original driver (OpenBSD's 
iwn driver in this case). OpenBSD uses a single MCLGETI call and no private 
storage. If necessary we use an adapter function to graft on the rbuf 


Home | Main Index | Thread Index | Old Index