tech-net archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: in_pcbbind() changes



Elad Efrat wrote:
Hey,

Attached is a diff implementing changes to in_pcbbind() similar to the
ones recently done in in6_pcbbind():

  - Add in_pcbbind_{addr,port}() and split functionality
  - Add in_pcbsetport() (almost an exact copy of in6_pcbsetport() that
    was open-coded inside in_pcbbind())
  - All three "static" for now, will be exposed if we decide to
  - Fix a bug where "sin" was passed to kauth(9) without being set to
    anything

Please review. :)


Hi,

You should check IN_MULTICAST(sin->sin_addr.s_addr) in in_pcbbind_addr() and always succeed in that case.

--
Mihai


Home | Main Index | Thread Index | Old Index