Re: in_pcbsetport(), in6_pcbsetport()

[David Young <dyoung%pobox.com@localhost>]

On Wed, Apr 29, 2009 at 08:01:33PM +0300, Elad Efrat wrote:
> Hi,
>
> Attached is a diff that implements the following changes:
>
>   - in6_pcbbind_{addr,port}() become static (I should have done this
>     before).
>
>   - in_pcbsetport(), in6_pcbsetport() properly authorize port binding.
>     This is just a first part, I'm about to add a new request to
>     indicate "auto-assign", but it shouldn't stand in the way of the
>     changes here.
>
>   - Pass sockaddr_in6 to in6_pcbsetport(), similarly to its netinet
>     counterpart. Craft one in udp6_output() where we don't have it in
>     our context.
>
>   - Don't pass "laddr" to the aforementioned functions, as it's
>     redundant now that both take a sockaddr_in{,6}.
>
> Please review. No change in functionality is expected, but I'd like
> eyes on this from people who are more familiar with the IPv6 stack.

I see at least one serious problem with this patch.  I need to go back
and review your previous patches in this area, too.  Please hold off
from committing this until I have had a closer look.  Thanks.

Dave

-- 
David Young             OJC Technologies
dyoung%ojctech.com@localhost      Urbana, IL * (217) 278-3933