Re: tso with vlan

[Thor Lancelot Simon <tls%rek.tjls.com@localhost>]

On Thu, Apr 02, 2009 at 03:57:39AM +0000, YAMAMOTO Takashi wrote:
> 
> it's actually used eg. when a packet filter redirect packets.
> i tested the code when i implemented it.
> i left the has_tso check because i saw negative performace effects
> when i tested.

Thanks!  I wondered about that (as well as how well tested the software
"offload" code was) or I would probably have just checked in the change
to remove has_tso -- it does seem to work that way, but I didn't do
extensive performance testing on platforms without TSO, or any
correctness testing beyong a couple of quick ttcp and tcpdump runs.

It's unfortunate how complex the has_tso/use_tso logic is, though.
Maybe if we can eventually better modularize SACK and congestion
control, and get some of those IPSEC ifdefs out of there, it will be
easier to read and understand.

Thor