[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: iwi(4) patch
On Sun, Mar 08, 2009 at 01:22:19AM +0100, Jean-Yves Migeon wrote:
> With a Xen debug kernel (PAE off), iwi(4) is not able to attach during
> autoconf ("XENMEM_decrease_reservation failed!" issue) on my laptop.
> This should not be fatal to the boot process, but in fact, it is; errors
> are (from my PoV) incorrectly handled in if_iwi.c.
> I have local fixes to it . However, as it is not a part of the kernel
> I am familiar with, I would like more experienced people to review my
> - some bus_dma fix, with checks against invalid dmap.
> - move the (RX and TX) rings' allocation code later in iwi_attach() to
> avoid NULL pointer dereference if allocation fails (iwi_detach()
> manipulates structure variables that are not set in case of a failed
> - avoid double free in case of failure during attach. If an allocation
> fails, do not free it directly, this is handled by iwi_detach() routine.
Judging by your patch alone, if iwi_attach() fails midway through,
it will leak resources, will it not?
David Young OJC Technologies
dyoung%ojctech.com@localhost Urbana, IL * (217) 278-3933
Main Index |
Thread Index |