Re: should rt_msg1() zero rt_msghdr?

[christos%zoulas.com@localhost (Christos Zoulas)]

On May 16,  2:33pm, jtc%acorntoolworks.com@localhost (J.T. Conklin) wrote:
-- Subject: Re: should rt_msg1() zero rt_msghdr?

| christos%astron.com@localhost (Christos Zoulas) writes:
| > In article <874p8y86v9.fsf%orac.acorntoolworks.com@localhost>,
| > J.T. Conklin <jtc%acorntoolworks.com@localhost> wrote:
| >>While debugging a problem with routing socket messages, I noticed that
| >>messages contained random data in the rtm_seq, rtm_pid, and rtm_errno
| >>fields.
| >>
| >>In TCP/IP Illustrated, rt_msg1() contains a bzero() to clear rt_msghdr
| >>fields.  This bzero() is not present in NetBSD-4 (which I am using) or
| >>in the -current sources.  
| >>
| >>Should a memset() be added where the bzero() used to be?
| >
| > Can you post a diff?
| 
| This patch with memset() is equivalent to the version in TCP/IP
| Illustrated that used bzero().  I'm building a kernel with this 
| change as I write this, so I haven't yet had a chance to verify 
| it.

I think this is right. Should the same be done in rt_msg2()?

christos