Re: Old thread: Re: Allowing large PPPoE frames

[Paul Ripke <stix%stix.id.au@localhost>]

On Mon, Apr 14, 2008 at 07:55:20AM +0200, Quentin Garnier wrote:
> On Mon, Apr 14, 2008 at 03:44:41PM +1000, Paul Ripke wrote:
> > On Mon, Apr 14, 2008 at 07:35:43AM +0200, Quentin Garnier wrote:
> > > On Mon, Apr 14, 2008 at 01:57:28PM +1000, Paul Ripke wrote:
> > > > Just wondering if anything happened to this old issue - I've just
> > > 
> > > <snip>
> > > 
> > > In that case, it's a 10 minute job to revive that patch, it was very
> > > simple after all.
> > 
> > I took a slightly more brutal approach. I just removed the "return"
> > from the check and passed all oversize frames through. Hey, it works.
> > The NIC is a gigabit sk that supports jumbo frames, so that part
> > works. I didn't find your patch until after I got it working. For
> > me, it was breaking large udp and icmp packets, possibly ipsec, too.
> > 
> > It's an annoying position to be in.
> 
> Well, Ethernet devices are not supposed to let such frames through;
> and as I said, I had an unusual setup (for various reasons) which
> broke down in that respect when I made my situation with my ISP
> "normal".
> 
> Think of your position still as a privileged one, as a PPPoE
> vict^Wuser.

Heh.

> What's the driver of your NIC?  I'll revive that patch, and get it
> committed as you will be able to test it.

As above, a Marvell/SysKonnect sk (if_sk.c) gigabit NIC. Since it
supports jumbo frames (~9000 bytes?) it just works. I should be able
to test any patches over the next week or so.

Cheers,
-- 
Paul Ripke