tech-net archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: MPLS patches

Joerg Sonnenberger wrote:
On Thu, Jan 03, 2008 at 05:53:54PM +0200, Mihai Chelaru wrote:
Opinions ?

In ether_input, you disable the check for maximum frame size, why?


Over ethernet, MPLS uses a 4 size header prepended between data and network layer. I wanted to be sure that ether_input() won't drop these baby giant frames.

In ip_output, you are destroying the indentation. I don't like the chunk
for 480/493 (in_broadcast).

Indentation check is on TODO list for all the code.

Have you tested that the checksumming is
done correctly?

Yes, mostly, I haven't seen much problems (except HW cksumming I've fixed sometime ago).

I wonder if some of the code above is cleaner if MPLS_IS_TAGGED is
always defined and just returns false for the !MPLS case.

I don't know. Why should it ? Code is #ifdef MPLS'ed everywhere currently.



Home | Main Index | Thread Index | Old Index