Re: MPLS patches

[christos%astron.com@localhost (Christos Zoulas)]

In article <477D0512.9080407%netbsd.org@localhost>,
Mihai Chelaru  <kefren%netbsd.org@localhost> wrote:
>Hi,
>
>I've uploaded at ftp://ftp.netbsd.org/pub/NetBSD/misc/kefren/mpls/ 
>patches for -current (of about one week ago) I use in order to get MPLS 
>working(kernel and LDP daemon). I'd like to commit that sooner better 
>than later :)
>
>Opinions ?

Looks fine.

- some ints should be size_t's [clen for example]
- KNF:
    void foo(void)
should be:
    void
    foo(void)
- You should not add MBUFTRACE to GENERIC
- a define<space> should be define<tab>
- Is there a way to avoid all the #ifdefs or abstract them better?
- Missing kernel RCSID's and /* $NetBSD$ */ header lines.
- #ifdef TAGS for protecting header files, don't follow convention.
- __attribute__((foo)) -> __attribute__((__foo__))
- casts to void* in the first argument of memset are not needed.
- some lines wrap > 80 chars.
- the third argument of memcpy() should be sizeof(arg1) not sizeof(type1).
- the copyright/license in ldpd files is BSD but formatted strangely. I'd
  replace it with the standard formatting.
- ldpd should use syslog to print errors, and not homegrown error routine
  that prints to stdout or perror.

I did not look at ldpd in detail, but I can after you fix the above...

Thanks for doing all this great work!

christos