Re: (tiny) patch review: return if RTC diag fails

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Thu, Feb 13, 2025 at 08:18:32PM +0100, Martin Husemann wrote:
> On Thu, Feb 13, 2025 at 08:11:29PM +0100, Manuel Bouyer wrote:
> > Are you suggecting that we should find another way to detect if the
> > mc146818 is present ? AFAIK it's the other way round: unless we know it's
> > not present (because e.g. we're in an environnement known to not have
> > it like some hypervisors or emulators) we have to assume it's present
> > (because it's a mandatory part of the hardware).
> 
> With newer ACPI version this is no longer the case (and windows does
> not require it anymore). Many mainboards do not emulate the legacy "AT"
> interface any more but use modern I2C connected clocks + nvram instead.

Yes, but this code is also used for older, non-ACPI PCes

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--