Re: (tiny) patch review: return if RTC diag fails

[Emile `iMil' Heitor <imil%home.imil.net@localhost>]

On Thu, 13 Feb 2025, Manuel Bouyer wrote:

> I think it's not right: mc146818_read(NULL, NVRAM_DIAG) returning a non--0
> value doens't means that is fails. Usually the RTC BIOS diagnostic has some
> error because the chip lost track of date/time (maybe because of a bad
> battery). In this case you still want to use the RTC.

Understood. So as this seems to only impact qemu/microvm should we
consider an if (vm) test?

> Did you check what value is returned in your case ?

255

------------------------------------------------------------------------
Emile `iMil' Heitor <imil@{home.imil.net,NetBSD.org}> | https://imil.net