On 18.05.2020 22:18, Christos Zoulas wrote:
On May 18, 2020, at 3:40 PM, Kamil Rytarowski <n54%gmx.com@localhost> wrote:
If I delete P_TASKID ... P_P_CPUID ones, P_SETID will be reordered (but
we can force the number anyway). If I delete P_CID there is an inelegant
hole. Naturally P_SETID -> P_CID can fill the gap.
This is in theory ABI change, but no users could use in a useful
approach previously.
My intention isto g/c unused values and keep this clean and elegant (as
this is still possible).
Why don't you leave them alone for the same reason FreeBSD did (source compatibility)
and append the ones you want? If you look they #define P_ZONEID P_JAILID when
they made the change...
christos
My point is that there is no source code (at least in base) that we gain
compatibility with, no ABI compatibility layer and these concepts do not
match the current NetBSD kernel features. If there is anything in 3rd
party pretending to use these values, it would not work anyway.
If we want to these compat defines, they already live in:
external/cddl/osnet/dist/uts/common/sys/procset.h
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=170346Regarding FreeBSD, I don't see rationale for inclusion of these values.
It looks like it was copy-pasted (there were also Solaris-specific
preprocessor guards in the initial version).
But if there is intention to keep these values around (as it might be in
theory too late as they leaked somewhere), it's fine. Thanks.