Re: netbsd32_{,u}int64 in sys/types.h for compat/sys/siginfo.h

[Rin Okuyama <rokuyama.rk%gmail.com@localhost>]

On 2019/11/20 20:12, Rin Okuyama wrote:
> On 2019/11/19 22:59, Kamil Rytarowski wrote:
...
> > We still miss compat32 support for PT_GETXMMREGS and PT_SETXMMREGS, at
> > some point of time we shall add it for completeness.
>
> Thank you!
>
> With amd64/netbsd32_machdep.c rev 1.130, all tests in t_ptrace* pass in
> COMPAT_NETBSD32 on amd64, except for that involved with XMM registers.
> I will examine how to implement PT32_[GS]ETXMMREGS.

I wrote a draft version of patch which adds PT32_[GS]ETXMMREGS support:

http://www.netbsd.org/~rin/amd64-PT32_GSETXMMREGS-20191121.patch

With this patch, XMM-related tests pass for COMPAT_NETBSD32 on amd64.

Some remarks:

(1) PT_[GS]ETXMMREGS ptrace(2) commands are added to <machine/ptrace.h>.
    These are only used for COMPAT_NETBSD32, and not exposed to userland.

(2) COMPAT_NETBSD32 codes are called from process_machdep.c via
    module_hook framework. This may be too much though...

Comments?

> Also, it seems that some COMPAT_NETBSD32 related codes for amd64 need to
> be cleaned up. For example, there remain COMPAT_NETBSD32 codes in
> amd64/process_machdep.c, that are no longer used:
>
> https://nxr.netbsd.org/xref/src/sys/arch/amd64/amd64/process_machdep.c#129
> https://nxr.netbsd.org/xref/src/sys/arch/amd64/amd64/process_machdep.c#183
> ...
>
> I will examine them too.

This was my misunderstanding. These codes are used when tracer is 64-bit
and traced is 32-bit. Don't know whether this is useful though...

Thanks,
rin