tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: netbsd32_{,u}int64 in sys/types.h for compat/sys/siginfo.h

On 2019/11/19 22:59, Kamil Rytarowski wrote:
On 18.11.2019 13:08, Rin Okuyama wrote:
On 2019/11/18 20:15, Kamil Rytarowski wrote:
I was thinking about something along these lines:

In future some compat of i386 could use 8-byte alignment for 64-bit

Not build tested.

Thank you for providing the patch. It looks fine for me. I committed
it with changes below:

- Take into account of __arm__ && __ARM_EABI__ for compat with arm-oabi
- Undefine NETBSD32_SIGINFO_UINT64_ALIGN for clarity


Great work!

Please try to run in compat32:

cd /usr/tests/lib/libc/sys
atf-run t_ptrace* | atf-report

We still miss compat32 support for PT_GETXMMREGS and PT_SETXMMREGS, at
some point of time we shall add it for completeness.

Thank you!

With amd64/netbsd32_machdep.c rev 1.130, all tests in t_ptrace* pass in
COMPAT_NETBSD32 on amd64, except for that involved with XMM registers.
I will examine how to implement PT32_[GS]ETXMMREGS.

Also, it seems that some COMPAT_NETBSD32 related codes for amd64 need to
be cleaned up. For example, there remain COMPAT_NETBSD32 codes in
amd64/process_machdep.c, that are no longer used:

I will examine them too.


Home | Main Index | Thread Index | Old Index