Re: [PATCH] Linux pselect6() implementation

[christos%astron.com@localhost (Christos Zoulas)]

In article <1mz6oz7.vasmawiih0haM%manu%netbsd.org@localhost>,
Emmanuel Dreyfus <manu%netbsd.org@localhost> wrote:
>Hello
>
>I seek comment regarding Linux's pselect6() implementation, which seems
>required to run Matlab R2016a on NetBSD/amc64:
>https://ftp.espci.fr/shadow/manu/pselect6.patch'
>
>1) The syscall has a 6th argument which is a pointer to a structure
>contianing { linux_sigset_t *, size_t }, but that structure is nameless
>in Linux: it is not defined anywhere. I named it as
>linux_sized_sigset_t, but perhaps someone has a better idea.
>
>2) The code was initially lifted from FreeBSD, I significally altered it
>to fit the NetBSD kernel. Where should the original copyright notice go?
>Or should I drop the comment and consider the code is different enough
>now?

This looks ok. I don't know if the code is different enough to drop the
comment, that is up to your judgement.

christos