Re: Brainy: some bugs

[David Holland <dholland-tech%netbsd.org@localhost>]

On Sun, Sep 06, 2015 at 02:36:07PM +0200, Maxime Villard wrote:
 > Le 30/08/2015 06:43, David Holland a ?crit :
 > > On Fri, Aug 28, 2015 at 11:17:24AM +0200, Maxime Villard wrote:
 > >  > _11/ UNINITIALIZED VAR: sys/dev/ic/sgec.c
 > >  > _12/ USE-AFTER-FREE: sys/arch/mips/alchemy/dev/aupcmcia.c
 > >  > _13/ MEMORY LEAK: sys/dev/ic/smc91cxx.c
 > >  > _15/ MEMORY LEAK: sys/arch/acorn26/ioc/arcpp.c
 > >  > _17/ MEMORY LEAK: sys/dev/ic/gem.c
 > >  > _18/ MEMORY LEAK: sys/dev/ic/rrunner.c
 > >  > _19/ USE-AFTER-FREE: sys/dev/ic/rrunner.c
 > > 
 > > These are all straightforward and now fixed.
 > > 
 > >  > _20/ MEMORY LEAK: sys/dev/spi/spiflash.c
 > > 
 > > It looks to me like this code leaks a scratch buffer on every write
 > > operation, not just on the path cited. Am I missing something?
 > 
 > Yes, you're right. But as I must have said somewhere, Brainy forgets
 > variables as soon as a bug is detected with them (per bug type). So
 > it only gives you the first leak.

It's not the brainy output I was questioning (it probably can't
readily tell if the call at the end of the function destroys the
buffer) but whether I was reading the code correctly. More on this in
a moment.

-- 
David A. Holland
dholland%netbsd.org@localhost