Re: Brainy: some bugs

[Maxime Villard <max%m00nbsd.net@localhost>]

Le 30/08/2015 06:43, David Holland a écrit :
> On Fri, Aug 28, 2015 at 11:17:24AM +0200, Maxime Villard wrote:
>  > _11/ UNINITIALIZED VAR: sys/dev/ic/sgec.c
>  > _12/ USE-AFTER-FREE: sys/arch/mips/alchemy/dev/aupcmcia.c
>  > _13/ MEMORY LEAK: sys/dev/ic/smc91cxx.c
>  > _15/ MEMORY LEAK: sys/arch/acorn26/ioc/arcpp.c
>  > _17/ MEMORY LEAK: sys/dev/ic/gem.c
>  > _18/ MEMORY LEAK: sys/dev/ic/rrunner.c
>  > _19/ USE-AFTER-FREE: sys/dev/ic/rrunner.c
> 
> These are all straightforward and now fixed.
> 
>  > _20/ MEMORY LEAK: sys/dev/spi/spiflash.c
> 
> It looks to me like this code leaks a scratch buffer on every write
> operation, not just on the path cited. Am I missing something?

Yes, you're right. But as I must have said somewhere, Brainy forgets
variables as soon as a bug is detected with them (per bug type). So
it only gives you the first leak.

> 
> ("save" in spiflash_process_write)
> 
>  > _14/ UNINITIALIZED VAR: sys/compat/linux/common/linux_futex.c
> 
> I have no idea what on earth this code's supposed to be doing, but
> it's obviously wrong the way it is.
> 
>  > _21/ USE-AFTER-FREE: sys/dev/ic/daic.c
> 
> This is also obviously wrong but it isn't clear what it should be
> changed to.
> 
>  > _09/ DOUBLE RUNTIME BRANCH: sys/arch/arm/arm/cpufunc.c
>  > _10/ MEMORY LEAK: sys/net/if_ieee1394subr.c
>  > _16/ MEMORY LEAK: sys/dev/pci/cxgb/cxgb_l2t.c
> 
> No opinion on these.
> 

Thanks for the fixes.
Maxime