tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

change MSI/MSI-X APIs



Hi,

I received feedback from some device driver authors. They point out
establish, disestablish and release APIs should be unified for INTx,
MSI and MSI-X. So, I would change the APIs as below:

 before                  | after (unify to)
-------------------------+-------------------------
 pci_intr_establish()    | 
 pci_msi_establish()     | pci_intr_establish()
 pci_msix_establish()    |
-------------------------+-------------------------
 pci_intr_disestablish() | 
 pci_msi_disestablish()  | pci_intr_disestablish()
 pci_msix_disestablish() |
-------------------------+-------------------------
 pci_intx_release()      | 
 pci_msi_release()       | pci_intr_release()
 pci_msix_release()      |
# In contrast, alloc APIs are not changed.

Here is the above modification diff.
    http://www.netbsd.org/~knakahara/unify-msi-apis/unify-msi-apis.diff

If there is no objection, I commit it in a few days.

Could you comment this modification?


Thanks,

-- 
//////////////////////////////////////////////////////////////////////
Internet Initiative Japan Inc.

Device Engineering Section,
Core Product Development Department,
Product Division,
Technology Unit

Kengo NAKAHARA <k-nakahara%iij.ad.jp@localhost>



Home | Main Index | Thread Index | Old Index