tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Patch: cprng_fast performance - please review.



tls@ wrote:

> > Note the caller of this hc128_init() is:
> > 
> > I'm afraid "9KB stack on rekeying" is fatal on most ports.
> 
> Well, the cipher should hardly ever get rekeyed.  The rekeying
> intervals could be considerably larger; I did not want to
> increase them too much compared to the old implementation.
> 
> We can kmem_alloc these structures instead.

If it's replaced kmem_alloc(9), it's okay for me.
(on NetBSD/x68k there are so many kernel stack overflow on loads)

> > I wonder if we should also consider "speed vs memory"
> > especially for embedded users.
> 
> It's 9K per CPU, total.  Seems OK, no?

I have no idea, but depend on pros and cons if it is not on stack?

---
Izumi Tsutsui


Home | Main Index | Thread Index | Old Index