tech-kern archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: Enhance ptyfs to handle multiple instances.
On Apr 4, 12:29pm, netbsd%izyk.ru@localhost (Ilya Zykov) wrote:
-- Subject: Re: Enhance ptyfs to handle multiple instances.
| >
| > - I don't like the refactoring because it makes ptyfs less optional (brings
| > in code and headers to the base kernel). I think it is simpler to provide
| > an entry function to get the mount point instead, and this way all the
guts
| > of ptyfs stay in ptyfs.
|
| Looks better, thank you.
|
| > - Is it important to append to the list? Then perhaps use a different set
| > of macros than LIST_. I've changed the code just to prepend.
| >
| > I hope I did not break it. Comments?
|
| Order IMPORTANT here, because, pty_getmp returns the first found,
| traditionally /dev/pts - must be persistently first(for security too).
| All others MPs are useful only inside chroot.
Should we put a pointer in the pty node that points to the primary mount point
then so we get the correct one? Or that does not work? I will change the list
so it always appends.
Thanks,
christos
Home |
Main Index |
Thread Index |
Old Index