tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: [PATCH] netbsd32 swapctl, round 4



> On Mon, Feb 03, 2014 at 03:06:14AM +0000, Christos Zoulas wrote:
> > I thought we decided that it is better to have one sep32 on the stack
> > and do copyout in the loop.
> 
> I can do that too, I just need to sort out the size question:
> 
> > >+out:
> > >+  kmem_free(sep, sizeof(*sep));
> > >+  kmem_free(sep32, sizeof(*sep32));
> > The sizes are wrong.
> 
> How are they wrong?

missing * count.  ouch.  kmem_free() is easy to use wrongly.


.mrg.


Home | Main Index | Thread Index | Old Index