tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: [patch] changing lua_Number to int64_t

Lourival Vieira Neto wrote:
> On Sat, Nov 16, 2013 at 8:52 PM, Christos Zoulas 
> <> wrote:
> > In article <>, Marc Balmer  
> > <> wrote:
> >>Changing the number type to int64_t is certainly a good idea.  Two
> >>questions, however:
> >
> > Why not intmax_t?
> My only argument is that int64_t has a well-defined width and, AFAIK,
> intmax_t could vary. But I have no strong feelings about this. Do you
> think intmax_t would be better?

int64_t should be enough to cover a range of exactly representable
integers in userspace Lua program where lua_Number is double.

I don't see a need for bigger type unless mainstream Lua switches to
long double. I don't expect it to happen any time soon.

PS Why do you still use a shadow copy of luaconf.h? Please add your
changes to the main luaconf.h. If you guard your kernel changes properly
with _KERNEL, they will not affect userspace.

PPS "%"PRId64 may break in C++11, space between the literals should fix it.


Home | Main Index | Thread Index | Old Index