tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: wapbl_flush() speedup

On Dec 4, 2012, at 8:10 PM, Michael van Elst <> 

> ("J. Hannken-Illjes") writes:
>> The attached diff tries to coalesce writes to the journal in MAXPHYS
>> sized and aligned blocks.
> [...]
>> Comments or objections anyone?
>> + * Write data to the log.
>> + * Try to coalesce writes and emit MAXPHYS aligned blocks.
> Looks fine, but I would prefer the code to use an arbitrarily sized
> buffer in case we get individual per device transfer limits. Currently
> that size would still be MAXPHYS, but then the code could query the driver
> for a proper size.

As `struct wapbl' is per-mount and I suppose this will be per-mount-static
it will be just a small `s/MAXPHYS/get-the-optimal-length/' as soon as
tls-maxphys comes to head.

J. Hannken-Illjes - - TU Braunschweig 

Home | Main Index | Thread Index | Old Index