tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: wapbl_flush() speedup ("J. Hannken-Illjes") writes:

>The attached diff tries to coalesce writes to the journal in MAXPHYS
>sized and aligned blocks.
>Comments or objections anyone?

>+ * Write data to the log.
>+ * Try to coalesce writes and emit MAXPHYS aligned blocks.

Looks fine, but I would prefer the code to use an arbitrarily sized
buffer in case we get individual per device transfer limits. Currently
that size would still be MAXPHYS, but then the code could query the driver
for a proper size.

                                Michael van Elst
                                "A potential Snark may lurk in every tree."

Home | Main Index | Thread Index | Old Index