tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: xorg pci probing



On Wed, Jan 19, 2011 at 09:28:02AM +0100, Christoph Egger wrote:
> On 19.01.11 09:19, Michael wrote:
> > Hello,
> > 
> > On Jan 19, 2011, at 3:08 AM, Christoph Egger wrote:
> > 
> >> On 19.01.11 00:22, Christoph Egger wrote:
> >>> On 19.01.11 00:09, David Young wrote:
> >>>> On Wed, Jan 19, 2011 at 08:18:40AM +1100, matthew green wrote:
> >>>>> David Young wrote:
> >>>>>> On Tue, Jan 18, 2011 at 11:22:33AM +0100, Christoph Egger wrote:
> >>>>>>> Moving that function into wsdisplay.c will add bus dependencies
> >>>>>>> to wsdisplay.c.
> >>>>>>
> >>>>>> I think I agree with Christoph here: if he avoids sprinkling
> >>>>>> wsdisplay.c
> >>>>>> with bus-related #ifdefs by adding new files, he should definitely do
> >>>>>> that.
> >>>>>
> >>>>> that's a good idea.
> >>>>>
> >>>>> since it's PCI specific, perhaps sys/dev/pci/wsdisplay_pci.c is
> >>>>> a better place?
> >>>>
> >>>> Sounds good.  Christoph, what do you think?
> >>>
> >>> The scheme sys/dev/<bus>/wsdisplay_<bus>.[ch] where <bus>
> >>> is pci, sbus, etc. is fine with me.
> > 
> >> When trying to do that I uncovered a problem with doing it:
> > 
> >> In sys/dev/pci/files.pci  I can't do 'wsdisplay & pci'
> >> because 'wsdisplay' is defined in sys/dev/wscons/files.wscons.
> > 
> >> So I will leave it as is for now and will do it later when a solution
> >> is found for that.
> > 
> > The drivers can ( and should ) pull it in themselves.
> 
> Oh, right. I just found 'wsemuldisplaydev' in files.pci.
> I retry.

Welcome to config design hell. 8-)

> 
> Christoph

-- 
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635


Home | Main Index | Thread Index | Old Index