-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello, On Jan 19, 2011, at 3:08 AM, Christoph Egger wrote:
On 19.01.11 00:22, Christoph Egger wrote:On 19.01.11 00:09, David Young wrote:On Wed, Jan 19, 2011 at 08:18:40AM +1100, matthew green wrote:David Young wrote:On Tue, Jan 18, 2011 at 11:22:33AM +0100, Christoph Egger wrote:Moving that function into wsdisplay.c will add bus dependencies to wsdisplay.c.I think I agree with Christoph here: if he avoids sprinkling wsdisplay.c with bus-related #ifdefs by adding new files, he should definitely dothat.that's a good idea. since it's PCI specific, perhaps sys/dev/pci/wsdisplay_pci.c is a better place?Sounds good. Christoph, what do you think?The scheme sys/dev/<bus>/wsdisplay_<bus>.[ch] where <bus> is pci, sbus, etc. is fine with me.When trying to do that I uncovered a problem with doing it: In sys/dev/pci/files.pci I can't do 'wsdisplay & pci' because 'wsdisplay' is defined in sys/dev/wscons/files.wscons. So I will leave it as is for now and will do it later when a solution is found for that.
The drivers can ( and should ) pull it in themselves. have fun Michael -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) iQEVAwUBTTaejMpnzkX8Yg2nAQIdxQf/TZIlzCFzSPoMrIYRb3964VprCcboc8O9 eCiJc5IJRxrt+pW1E5y2kU299d/1NriU1dpcwxqhy6wSXfOGMdzM1/BVh8uUUa/7 rvv5faQ8B56gUrp3Gf2+Z0CjIfofirxdeUZL+IwBKrXuHFRmCfTQkET+Duskhjz/ n40FkwUb/E48LMCGDGMr+57UsGHMxYOt+XmYnObUcr7j8wO4TMHLkrMZCC+To1Zj BbNuMFiCSZa2Y8DJE1tGljlHLzzowV/3zd0YOAKLXNvLKErtsqCYG3ssjobJovIo v9NJSvXCOeriD33Ytb7MOOu9mF9oq3qGRbDCbl7Go789+Zh8rZ0FOw== =CXu1 -----END PGP SIGNATURE-----