-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello, On Jan 18, 2011, at 2:17 PM, David Young wrote:
On Tue, Jan 18, 2011 at 11:22:33AM +0100, Christoph Egger wrote:i like this look of this much better than prior patches. thanks for doing this properly. i just have one minor suggestion. i don't see the point in the two new files with one function proto and a 5 line function. can you please move them into wsdisplay.c and wsdisplayvar.h? thanks.The reason is that the new function adds dependencies to the different busses. Currently only for PCI. But other busses may be added in future. Moving that function into wsdisplay.c will add bus dependencies to wsdisplay.c.I think I agree with Christoph here: if he avoids sprinkling wsdisplay.cwith bus-related #ifdefs by adding new files, he should definitely do that.
I suggested to put them in a separate file for just that reason so drivers that need them can pull them in without #ifdef orgies all over the place.
have fun Michael -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) iQEVAwUBTTXrAspnzkX8Yg2nAQJ6CQf/UMlyWwqV5Wp7ND6A+JgxXMG2QZlDyQhP rKuvm1m8apwbrm3m5NRjU+U4qN/PCcfjxkfxAT7ThTReQNueh9SbRMWmIY8QcQu3 3pKD4r2RrHT00GxaiBSe14OfhXgod5WbmC/+XM7aJPBFvp9noHBEmSKA8AXzq3AY it+As9y4poBup1nNurvodLR2jvGomuWHtXOhD2UH1voUqQ6LSwyINnurU76bHl++ 4ChDLs86ub9WO5VUY0mrs9ZosWyEecV9y+lUUnz5gKs80mIMvPvU9NGifKrScmOF mxktvJ4K/rjlTAtX0mWZ44/iO8WRW7t9rqt6rcHO8zBvYhsqB0MXfg== =uhvM -----END PGP SIGNATURE-----