tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: wedges on vnd(4) patch

On Jun 21, 11:52am, (Jeff Rizzo) wrote:
-- Subject: Re: wedges on vnd(4) patch

| On Mon, Jun 21, 2010 at 02:45:42PM +0000, Christos Zoulas wrote:
| > 
| > - declare the variables on top to avoid braces in case statements.
| > - KNF continuation lines (indent-by-four) and lose the ()'s around return
| Updated patch below.  As an aside, this ss clearly more KNF, but I have to
| say it's harder to follow (not that this is all that complex) with the
| variable declaration so far separated from its usage.  But I suppose
| that's another conversation for another day.  :)

I agree :-), please commit it.


Home | Main Index | Thread Index | Old Index