tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Using emap for i386/amd64 early during boot

On 20.06.2010 22:19, David Young wrote:
On Sun, Jun 20, 2010 at 07:45:32PM +0200, Jean-Yves Migeon wrote:
For convenience, here's i386_cpu_switch_pmap:

I know that a lot of legacy code uses the preprocessor the way that you
have in i386_cpu_switch_pmap(), but I don't think that the preprocessor
should be used in that way any longer.  In my experience, code that uses
the preprocessor heavily is harder to read and to change and to test.
Why don't you let config(1) and ld(1) do the work that the preprocessor
does?  For example:

I like that. Will do. Thanks!

Jean-Yves Migeon

Home | Main Index | Thread Index | Old Index