Re: biodone() and splbio ?

[Andrew Doran <ad%NetBSD.org@localhost>]

On Tue, Jan 19, 2010 at 10:46:26PM +0000, Mindaugas Rasiukevicius wrote:
> Manuel Bouyer <bouyer%antioche.eu.org@localhost> wrote:
> > On Tue, Jan 19, 2010 at 10:43:04PM +0100, Manuel Bouyer wrote:
> > > [...]
> > > If not, dk.c needs to be fixed to raise to splbio() in its done routine.
> > > raidcframe already does it. I suspect ccdiodone() and vndiodone()
> > > need it too.
> > 
> > Maybe not; it seems ccd is MP-safe.
> > For vnd, the lack of appropriate spl call here can corrupt sc_active count,
> > but it seems it can't corrupt the buffer queue.
> 
> While it is MP-safe, I wonder why sc_iolock is not IPL_BIO?
> It looks like a bug to me.

Because the notifications are not processed directly from hardware interrupt
handlers. ccd has no real hardware and no real hardware interrupt and so
doesn't need any messing about with hardware IPLs.