tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: biodone() and splbio ?

On Tue, Jan 19, 2010 at 10:43:04PM +0100, Manuel Bouyer wrote:
> [...]
> If not, dk.c needs to be fixed to raise to splbio() in its done routine.
> raidcframe already does it. I suspect ccdiodone() and vndiodone()
> need it too.

Maybe not; it seems ccd is MP-safe.
For vnd, the lack of appropriate spl call here can corrupt sc_active count,
but it seems it can't corrupt the buffer queue.

> cgdiodone() definitively needs it as the comment says it needs to be called
> at splbio. 

The buffer queue could be corrupted here, because of this.

Too bad we don't have a geenric SPLASSERT() for this kind of stuff ...

Manuel Bouyer <>
     NetBSD: 26 ans d'experience feront toujours la difference

Home | Main Index | Thread Index | Old Index