tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pseudoify cgd

On Thu, 31 Dec 2009, Quentin Garnier wrote:

>   - I looked at the code the other day, and I don't see any reason to
>     allocate a cfdata_t for each device_t.  I'm fairly certain you can
>     just use a static one common to all instances.  I know all the other
>     drivers do that, but that's just people copy-pasting code without
>     really understanding it (I'm just as guilty as the others).

I looked at that once also and came to the conclusion that while it would
probably work fine, it was better to allocate because the cfdata is not
specified as const in any documentation and indeed, config_attach_pseudo()
does modify it in certain cases which I didn't necessarily understand..


Home | Main Index | Thread Index | Old Index