Re: Deferred freeing of kauth_cred_ts

[David Young <dyoung%pobox.com@localhost>]

On Fri, Dec 25, 2009 at 09:25:49AM +0000, Iain Hibbert wrote:
> On Fri, 25 Dec 2009, Elad Efrat wrote:
> 
> > > +       SLIST_INSERT_HEAD(&kauth_thread_discard, cred, cr_list);
> > >
> > > should access to this SLIST be protected by a mutex?  There could be a
> > > race between adding and removing..
> >
> > Yeah... would an IPL_HIGH mutex be fine there? (if I read mutex(9)
> > right, we need a spin mutex for our purposes.)
> 
> Mm, I think you are right - guess you only need to hold it while accessing
> the list (drop it before the free), unless there is a better method?
> (somebody was working on atomic queues IIRC but I don't know how far along
> that work is..)

It's committed, but there is no manual page.  See sys/kern/subr_pcq.c.

Dave

-- 
David Young             OJC Technologies
dyoung%ojctech.com@localhost      Urbana, IL * (217) 278-3933