Re: Reclaiming vnodes

[Alan Barrett <apb%cequrux.com@localhost>]

On Sun, 30 Aug 2009, Adam Hamsik wrote:
> --- sys/sysctl.h      22 Jul 2009 22:53:41 -0000      1.185
> +++ sys/sysctl.h      29 Aug 2009 07:36:36 -0000
> @@ -277,7 +277,8 @@ struct ctlname {
>  #define      KERN_SYSVIPC            82      /* node: SysV IPC parameters */
>  #define      KERN_BOOTTIME           83      /* struct: time kernel was 
> booted */
>  #define      KERN_MAXID              84      /* number of valid kern ids */
> -
> +#define KERN_VNODES_HIWAT       85      /* int: max percentage of used 
> vnodes */
> +#define KERN_VNODES_LOWAT       86      /* int: min percentage of used 
> vnodes */

It is not necessary to define new sysctl integer constants here.  Pass
CTL_CREATE instead of KERN_FOO in the call to sysctl_createv(9), and
it will allocate its own integer for internal use.  As far as I know,
explicit numeric values should never be used except for backward
compatibility.  (If this is indeed the case, somebody should add a big
comment to sys/sysctl.h.)

--apb (Alan Barrett)