Re: More KAUTH_GENERIC_ISSUSER replacements

[yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi)]

hi,

> Hi,
> 
> I would like to introduce the following actions/requests as alternatives
> to some KAUTH_GENERIC_ISSUSER uses:
> 
>   - KAUTH_SYSTEM_MOUNT::KAUTH_REQ_SYSTEM_MOUNT_UMAP: special request for
>     mounting a umapfs. See miscfs/umapfs/umap_vfsops.c.

isn't it better to make KAUTH_REQ_SYSTEM_MOUNT_NEW take the filesystem type?

if you want a check for changing credentials,
it doesn't really belong to KAUTH_SYSTEM_MOUNT, i guess.

> 
>   - KAUTH_SYSTEM_RESOURCE_RESERVEDSPACE: action for checking whether the
>     reserved space allocated on the file-system can be used. See
>       ufs/ext2fs/ext2fs_alloc.c and ufs/ffs/ffs_alloc.c.
> 
>   - KAUTH_SYSTEM_RESOURCE_QUOTA::KAUTH_REQ_SYSTEM_RESOURCE_QUOTA_ with
>     NOLIMIT (check if the quota limit can be bypassed), GET (for reading
>       quota information), and MANAGE (check whether the caller can manage
>       quota by enabling/disabling it and setting quota for users). See
>       ufs/ufs/ufs_quota.c and ufs/ufs/ufs_vfsops.c.

these should be named to imply that they are filesystem-related.
sorry, no good name from me. :)

YAMAMOTO Takashi

> 
> Are there objections for any of the above?
> 
> Thanks,
> 
> -e.