Re: defflag for MODULAR option

[Alan Barrett <apb%cequrux.com@localhost>]

On Mon, 19 Jan 2009, Izumi Tsutsui wrote:
> > I have patches to add "defflag MODULAR" to src/sys/conf/files
> > and to add #include "opt_modular.h" to everything that tests
> > the MODULAR option.  A test build on i386 works.
> > 
> > The patc is at
> > <ftp://ftp.netbsd.org/pub/NetBSD/misc/apb/defflag-modular.20090118.diff>
> > 
> > Is it OK in principle to commit this?
> 
> We should ask Andrew why he removed the defflag for MODULAR
> on LKM removal?
> http://cvsweb.NetBSD.org/bsdweb.cgi/src/sys/conf/files#rev1.925

That commit touched many files:
<http://mail-index.netbsd.org/source-changes/2008/11/12/msg212586.html>

It deleted '#include "opt_modular.h"' from only three files:

    src/sys/arch/x86/x86/x86_machdep.c
    src/sys/kern/kern_module.c
    src/sys/kern/subr_kobj.c
 
and it converted from #ifdef LKM or similar to #ifdef MODULAR or similar
in many files.  My patch adds '#include "opt_modular.h"' to all the
files that now use #ifdef MODULAR or similar.

--apb (Alan Barrett)