tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/kern

> Date:         Sun Nov  9 12:18:07 UTC 2008
> Modified Files:
>       src/sys/kern: kern_physio.c
> Log Message:
> Assert that bp->b_error == 0 if all data have been transfered in
> physio_biodone(). We have more chance to have the fauly code in the
> stack trace when doing the check here than in physio_done().

Asserting this makes it impossible to skip any buffers with nestio.
Either we introduce a concept "handled but not done" into buf or stop
asserting things like this.  I'm not sure which is better.  buf is complex
enough already so that 95% of the calling code is probably incorrect,
but then again asserts would catch errors.  Thoughts?

(I didn't have a commit email to the original assert handy, therefore
I'm replying to this.  But in no way did this change cause the problem).

Home | Main Index | Thread Index | Old Index